Skip to content

fix: correct workspace type property linking API contract#45

Merged
Prashant-Surya merged 2 commits into
mainfrom
fix-link-property-type
Jun 1, 2026
Merged

fix: correct workspace type property linking API contract#45
Prashant-Surya merged 2 commits into
mainfrom
fix-link-property-type

Conversation

@akhil-vamshi-konam

@akhil-vamshi-konam akhil-vamshi-konam commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Description:

Description

The workspace work item type properties endpoint (POST /workspaces/{slug}/work-item-types/{type_id}/properties/) expects a properties array, not a single property_id. The endpoint also returns HTTP 201 with no response body.

Changes:

  • WorkspaceWorkItemTypePropertyLink: property_id: str → properties: list[str] to match API contract
  • WorkspaceWorkItemTypeProperties.create(): removed response parsing (model_validate) since API returns empty 201

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Test Scenarios

  • Link a single property to a workspace work item type → returns 201, no error
  • Link multiple properties in one call → accepted by API

@coderabbitai

coderabbitai Bot commented Jun 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@akhil-vamshi-konam, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 59 minutes and 16 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fb540c27-6e95-4d7a-8b6f-6e45cdb46556

📥 Commits

Reviewing files that changed from the base of the PR and between 2c0aa28 and 9b8a846.

📒 Files selected for processing (2)
  • plane/api/workspace_work_item_types/properties.py
  • plane/models/work_item_types.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-link-property-type

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Prashant-Surya Prashant-Surya merged commit a105871 into main Jun 1, 2026
1 check passed
@Prashant-Surya Prashant-Surya deleted the fix-link-property-type branch June 1, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Prashant-Surya Prashant-Surya Prashant-Surya approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@akhil-vamshi-konam @Prashant-Surya